NIH | National Cancer Institute | NCI Wiki  

Error rendering macro 'rw-search'

null

Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • This is a "best coding practice" - the search specific implementation of Lucene should not be embedded in the LexEVS code base.  This work, whether it is completed or not will have no impact on the overall Lucene 5.0 implementation.
  • The decoupling task will move the search specific code to an implementation of a new search interface.  If the need ever arose to swap out Lucene for a different search engine, we would be able to create a new implementation of the search interface with the new search engine and not have to make changes in the LexEVS code base.

Recommendation

Based on our review of the code and the large effort needed to complete this decoupling task, we recommend that this decoupling task be lowered in priority and postponed until the main Lucene 5.0 implementation is complete.  At this time we can consider if we should take on this task.

Approach

Before we look at the decoupling task, the approach will be to first update to Lucene 5.0 and fix all of the old Lucene references to get the new Lucene working. We will need to upgrade to Lucene 5.0 first because there will be a lot of Lucene API changes as well as some obsolete Lucene objects that will need to be removed or replaced.  If the decoupling task was done before this with the existing Lucene version, we would have to make additional changes once Lucene 5.0 is implemented.

...

Once the Lucene 5.0 implementation is complete, we should discuss the priority of this task again.

Recommendation

Based on our review of the code and the large effort needed to complete this decoupling task, we recommend that this decoupling task be lowered in priority and postponed until the main Lucene 5.0 implementation is complete.  At this time we can consider if we should take on this task. 

Design

In order to remove the Lucene references from the LexEVS core code base, we will design a new search API interface.  We would then be able to create a specific Lucene implementation of this interface.  If there was ever a need to substitute different search engine, all that would be necessary would be to create a new implementation of the search API interface for the new search engine.  The LexEVS core code base would not be needed to be modified.

 

<Search Interface Image here >Image Added

 

There are several classes that will need to evaluated when doing the actual implementation.  These cases include code where Lucene objects are intermixed throughout LexEVS methods. (This is not an all inclusive list)

...